Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide grid selection column using JavaScript #171

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

flang
Copy link
Collaborator

@flang flang commented Jan 19, 2024

Hiding grid selection column with CSS breaks keyboard navigation

Close #156

Hiding grid selection column with CSS breaks keyboard navigation

Close #156
@flang flang requested review from javier-godoy and paodb January 19, 2024 13:06
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested also with Vaadin 24.3.3 and works okay. Just one note: currently, releases for this add-on are done on branch/version 2.x so this fix should be backported to that branch also.

@javier-godoy javier-godoy merged commit 8b3326e into master Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility when using tab key
3 participants